Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-size="fullscreen" does not work #32

Open
MichaelMorett opened this issue Sep 23, 2022 · 3 comments
Open

data-size="fullscreen" does not work #32

MichaelMorett opened this issue Sep 23, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@MichaelMorett
Copy link

MichaelMorett commented Sep 23, 2022

This seems simple enough, but controlling the size of the lightbox via data-size does not work. It only uses the default "xl".

Maybe this could be controlled by Javascript, but there is no working example in the docs that show this. All examples show control via data- attributes.

Using v1.8.0.

@trvswgnr trvswgnr added the bug Something isn't working label Sep 23, 2022
@trvswgnr
Copy link
Owner

@MichaelMorett Thanks for bringing this to my attention, I will look into it ASAP.

@Zenko
Copy link

Zenko commented Aug 30, 2023

It's been a year... has this been fixed?

I would really like to use this script, thanks.

@1xn
Copy link

1xn commented Nov 18, 2023

If you download the .js file and host it yourself, instead of loading it from the CDN it's easy to change.
On line 37 beginning of the script replace size: 'xl', with size: 'fullscreen' and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants