Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using setGlobalEachLevelOptions discards message #1

Closed
fref opened this issue Jan 3, 2020 · 5 comments
Closed

using setGlobalEachLevelOptions discards message #1

fref opened this issue Jan 3, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@fref
Copy link

fref commented Jan 3, 2020

if I set, for instance, a specific ToastOption for error message to have them displayed without timeout, using setGlobalEachLevelOptions, the message gets erased.

	public Toast setToastOption(IToastOption option) {
		this.option = Args.notNull(option, "option");
		return this;
	}

should probably use option.overwrite() to merge the options with the per-level defaults and the message.

@try0
Copy link
Owner

try0 commented Jan 4, 2020

Thank you for your feedback.
You're right.

I will fix in a few days!

@fref
Copy link
Author

fref commented Jan 4, 2020

Thank you. It's a very nice integration.

@try0 try0 added the bug Something isn't working label Jan 4, 2020
@try0
Copy link
Owner

try0 commented Jan 4, 2020

I have fixed and released.
You should be able to update in a matter of hours.
Please update version to 0.3.1

if you still have problems, please reopen this issue.

Thanks @fref .

@try0 try0 closed this as completed Jan 4, 2020
@fref
Copy link
Author

fref commented Jan 6, 2020

arigato gozaimashita

@try0
Copy link
Owner

try0 commented Jan 6, 2020

douitashimasite! You are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants