Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLDatabase #75

Open
HavenDV opened this issue Nov 20, 2023 · 2 comments
Open

SQLDatabase #75

HavenDV opened this issue Nov 20, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@HavenDV
Copy link
Contributor

HavenDV commented Nov 20, 2023

Project: LangChain.Utilities.SqlDatabase

  • You can omit the base class implementation. Just one file where this works is enough, we'll highlight the interfaces a bit later.
  • You can use GPT-4 for initial implementation
  • Tests are encouraged but not required. It's better to do something minimal than nothing.

References:

@HavenDV HavenDV mentioned this issue Nov 20, 2023
@khoroshevj
Copy link
Collaborator

khoroshevj commented Nov 23, 2023

I think I've got this one for postgres

@khoroshevj
Copy link
Collaborator

after merging #83 there are few moments missing and some improvements can be made in base class:

  • index in table info (missing)
  • view support (missing)
  • check readonly permission (improvement)

@HavenDV HavenDV added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

2 participants