Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor comment error in node_tracers #46

Open
gareth-robinson opened this issue Feb 24, 2017 · 0 comments
Open

Minor comment error in node_tracers #46

gareth-robinson opened this issue Feb 24, 2017 · 0 comments

Comments

@gareth-robinson
Copy link

In node_tracers.js for RawRESTkinHTTPTracer there is the comment "This implementation posts all traces immediately and does not implement buffering". Then there is RESTkinHTTPTracer, which uses the RawRESTkinHTTPTracer with the BufferingTracer and so doesn't have the comment above

For RawZipkinQueryServiceHTTPTracer there is similarly the comment "does not implement buffering of any sort". Then there is ZipkinQueryServiceHTTPTracer which uses the RawZipkinQueryServiceHTTPTracer with the BufferingTracer. However, the comment above ZipkinQueryServiceHTTPTracer also says "does not implement buffering of any sort" - so is this last comment a mistake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant