Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass components #26

Closed
mrmartineau opened this issue Jun 10, 2014 · 3 comments
Closed

Sass components #26

mrmartineau opened this issue Jun 10, 2014 · 3 comments

Comments

@mrmartineau
Copy link
Member

I've been thinking about adding some more sass components, these could be simple like we have already or more involved like the off-canvas/drawer navigation, with JS included etc.

Are there any that you'd like to include?

/cc @ashleynolan @CiaranPark @nicbell

@mrmartineau mrmartineau added this to the v4.0.0 milestone Jun 10, 2014
@ashleynolan
Copy link
Contributor

I think this is definitely a good idea, but I think it would be good to separate out KO's core components and additional optional ones.

Otherwise I can see the components directory growing to a bit of a mammoth size.

Maybe we can change structure of partials to be core-components (which would have things like buttons, code, forms, lists, tables etc) and then another folder (name tbc!) with things like menu components, tabs, wells, and anythign else we would like to add.

What do you think?

@mrmartineau
Copy link
Member Author

I think all of the components we have are core components, so I am not sure another directory is needed. Perhaps another could be added for project-specific components.

@mrmartineau
Copy link
Member Author

Just an update.. some components have been removed, some have been updated. This newer version of Kickoff is about making it leaner and more robust

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants