Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTML Validation Task #35

Closed
ashleynolan opened this issue Sep 5, 2014 · 7 comments
Closed

Add HTML Validation Task #35

ashleynolan opened this issue Sep 5, 2014 · 7 comments
Assignees
@ashleynolan
Labels
enhancement feature grunt

Comments

@ashleynolan
Copy link
Contributor

Would be cool to add HTML Validation as a separate task in grunt.

Thinking this shouldn’t run on watch, but perhaps we should consider creating a test set of tasks and add it to that, leaving us scope to add JS testing tasks at a later date.

This grunt plugin looks like it should do the job https://www.npmjs.org/package/grunt-html-validation
@mrmartineau
Copy link
Member

Sure, good idea. But would it validate a site or templates?

@ashleynolan
Copy link
Contributor Author

I guess if we could make it give a report, it’s down to the dev to choose to act on the results then. It wouldn’t be a breaking validation task like JSHint can be though.

@mrmartineau
Copy link
Member

I suggest that you make a branch for this and test it out.

@ashleynolan
Copy link
Contributor Author

Yep, will do when I get some downtime

@mrmartineau
Copy link
Member

friendly ping :)

@ashleynolan
Copy link
Contributor Author

Just to let you know, I’ve started working on this to try and get it into the v5 build.

Don’t think it should take too long, so will carry on with this and the Statix updates tomorrow.

ashleynolan added a commit that referenced this issue May 14, 2015
@ashleynolan
Adding feature for HTML Validation to kickoff checks. See issue #35 f…
df7f143 
…or more details.
@ashleynolan
Copy link
Contributor Author

This is now implemented ready for v5 release.

mrmartineau added a commit that referenced this issue May 14, 2015
@mrmartineau
Merge branch 'next' of https://github.com/tmwagency/kickoff into next
5bf555d 
# By Ashley Nolan
# Via Ashley Nolan
* 'next' of https://github.com/tmwagency/kickoff:
  Updating .htaccess to latest HTML5 boilerplate version
  Adding testing folder to the gitignore
  Adding feature for HTML Validation to kickoff checks. See issue #35 for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashleynolan ashleynolan

Labels
enhancement feature grunt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrmartineau @ashleynolan