Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API fetches stops when not in the query #38

Closed
EddyIonescu opened this issue Mar 17, 2019 · 1 comment · Fixed by #39
Closed

API fetches stops when not in the query #38

EddyIonescu opened this issue Mar 17, 2019 · 1 comment · Fixed by #39
Labels
bug

Comments

@EddyIonescu
Copy link
Member

Actual: fetches stops regardless of whether the field's included in the query
Expected: shouldn't do so as it's an unnecessary network call
@EddyIonescu
Copy link
Member Author

See

tryn-api/resolvers.js

Line 56 in 184b497

let stopsByRoute = {};
for more context

@youngj youngj mentioned this issue Mar 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

avoid fetching stops when the client doesn't request them trynmaps/tryn-api
1 participant
@EddyIonescu