Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine/rest: market names between exchanges are very inconsistent #1

Closed
tryphe opened this issue Aug 5, 2019 · 2 comments
Closed

Comments

@tryphe
Copy link
Owner

tryphe commented Aug 5, 2019

Trying to differentiate between market names on different exchanges sucks. Need to combine them. Formatting is:

Poloniex: BASE_QUOTE
Bittrex: BASE-QUOTE
Binance: QUOTEBASE

Maybe I'll just convert everything to do BASE_QUOTE. The other option would be to split it into 2 strings, which changes more stuff, so prefer not to do it this way. Update: We want to support the concept of base currency and quote currency separately now, because of the way spruce strat takes currency names and applies them to the base.

@tryphe tryphe changed the title market names between exchanges are a hassle engine/rest: market names between exchanges are very inconsistent Aug 27, 2019
@tryphe
Copy link
Owner Author

tryphe commented Sep 21, 2019

Update: accepted formats for input are BASE-QUOTE and BASE_QUOTE for all exchanges. "Fixed" (this is just a refactor for later code) in ab3e8f8 0500676 2fa64e3 cffa65c 706fb4f 3f97a9c cad9a45

@tryphe tryphe closed this as completed Sep 21, 2019
@tryphe tryphe reopened this Sep 21, 2019
@tryphe tryphe closed this as completed Sep 21, 2019
@LeviathanJGG
Copy link

LeviathanJGG commented May 10, 2024 via email

@github-staff github-staff deleted a comment from taylorcammack May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@tryphe @LeviathanJGG and others