Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current docker image doesn't support llvm upstream #47

Closed
Fraer opened this issue Aug 5, 2019 · 9 comments
Closed

Current docker image doesn't support llvm upstream #47

Fraer opened this issue Aug 5, 2019 · 9 comments

Comments

@Fraer
Copy link

Fraer commented Aug 5, 2019

If env var EMCC_WASM_BACKEND=1

When calling any of emconfigure or emcc, etcc ...

emcc: WASM_BACKEND selected but could not find lld (wasm-ld): /emsdk_portable/llvm/clang/bin/wasm-ld
@trzecieu
Copy link
Owner

Hi @Fraer current docker images base on fastcomp backend (instead of llvm upstream)
I'm putting some work to either support both of switch to upstream. It's related to: emscripten-core/emsdk#188
I'm keeping this issue open and will close once LLVM backend is added.

Thank you for reporting!

@sbc100
Copy link

sbc100 commented Aug 20, 2019

So is this an issue with the docker image? Can you re-title it accordingly please?

@trzecieu trzecieu changed the title Could not find lld when EMCC_WASM_BACKEND=1 Current docker image doesn't support llvm upstream Aug 20, 2019
@kripken
Copy link

kripken commented Aug 30, 2019

@trzecieu it looks like you added upstream backend support, so we can close this? Thanks!

Btw, are there docs for how to use the upstream backend there?

@trzecieu
Copy link
Owner

Hi @kripken, upstream backend isn't added yet, I was fighting with recovering fastcomp llvm.

@kripken
Copy link

kripken commented Sep 3, 2019

I see, thanks @trzecieu

@trzecieu trzecieu mentioned this issue Sep 8, 2019
@trzecieu
Copy link
Owner

trzecieu commented Sep 8, 2019

Fixed now:

trzeci/emscripten-upstream

➜ docker run --rm -it trzeci/emscripten-upstream:latest clang --version
clang version 10.0.0 (/b/s/w/ir/cache/git/chromium.googlesource.com-external-github.com-llvm-llvm--project 4e71702cd4ab2c77aaa753770e99526085e5e6eb)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /emsdk_portable/upstream/bin

And how it looked like:
trzeci/emscripten

clang version 6.0.1 (https://github.com/emscripten-core/emscripten-fastcomp-clang 98df4be387dde3e3918fa5bbb5fc43e1a0e1daac) (https://github.com/emscripten-core/emscripten-fastcomp 1b4148f39a69c7fc62edadd85e4122b68694dfb7) (emscripten 1.38.31 : 1.38.31)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /emsdk_portable/clang/tag-e1.38.43/build_tag-e1.38.43_64/bin

This is a first implementation, which is not size optimized yet and it's 100MB larger than fastcomp version of the same image. Nonetheless, it should be fully functional now!

Cheers,

@trzecieu trzecieu closed this as completed Sep 8, 2019
@kripken
Copy link

kripken commented Sep 10, 2019

Great news, thanks @trzecieu !

@forderud
Copy link
Contributor

Thank's a lot @trzecieu. I'll be looking forward to testing the new "upstream" container.

One small comment: Would it be possible for you to add some documentation to https://hub.docker.com/r/trzeci/emscripten-upstream/ that explains if "emscripten-upstream" contain the same content as "emscripten" or "emscripten-slim"?

@trzecieu
Copy link
Owner

Definitely will do, I'm doing some clean-up and improving documentation on another branch, cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants