Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackoverflow #9

Closed
kloetzl opened this issue Sep 25, 2017 · 2 comments
Closed

Stackoverflow #9

kloetzl opened this issue Sep 25, 2017 · 2 comments
Assignees
Labels

Comments

@kloetzl
Copy link
Contributor

kloetzl commented Sep 25, 2017

MAX_SEQ is defined as 1000000 which requires massive amounts of stack memory for compute_distance_matrix (15MB). Too much for my system, which only allows 8MB, thus triggering a segfault. I think 1000 should be a reasonable default value; or switch to a heap allocated dynamic array. In any case, N should be checked to not exceed MAX_SEQ.

@kloetzl
Copy link
Contributor Author

kloetzl commented Sep 26, 2017

In any case, N should be checked to not exceed MAX_SEQ.

This is actually very important, as it it surprisingly easy to produce a bad estimate:

>very-long-name
A
>p
A
>q
A

@tseemann tseemann self-assigned this Feb 21, 2018
@tseemann tseemann added the bug label Feb 21, 2018
@tseemann
Copy link
Owner

Agreed - lazy programming on my part. Will change to dynamic heap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants