Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report plot with status code detail #108

Closed
davideicardi opened this issue Dec 31, 2014 · 6 comments
Closed

Report plot with status code detail #108

davideicardi opened this issue Dec 31, 2014 · 6 comments

Comments

@davideicardi
Copy link

Do you think it is possible to plot a report where each status code is drawed in its own line?
For example let's say that I execute 200 request, 50 requests have HTTP 200, 150 have HTTP 500. I think it should be useful to have different lines in the output.

regards
Davide Icardi

@tsenart
Copy link
Owner

tsenart commented Dec 31, 2014

@davideicardi: That's what happens. Errors are drawn as red, otherwise green.

@davideicardi
Copy link
Author

I'm executing the following command:

echo "GET http://httpstat.us/500" | vegeta attack -duration=10s -rate=2 | tee results.bin | vegeta report -reporter=plot > plot.html

The page always return a 500 http code, but I get only a single green line. I'm doing something wrong?
Maybe I missing something...sorry I'm new to GO lang.

@tsenart tsenart closed this as completed in 96f5fb4 Jan 2, 2015
@tsenart
Copy link
Owner

tsenart commented Jan 2, 2015

This was a bug. Thanks for finding it and reporting! https://github.com/tsenart/vegeta/releases/tag/v5.5.1

@davideicardi
Copy link
Author

Thanks very much for your prompt response and fix!

Unfortunately I think that there is one more little problem: often pages that return 500 also return complex HTML error pages. For example:

Other times the page is empty:

With your last commit you write the body of the page as the error, correct me if I'm wrong. But this can a problem because it is a waste of memory, the message is a complex HTML difficult to read or worst an empty message that potentially can cause the page to be considered OK by the reporter.

My suggestion is to just put the HTTP status or description like "HTTP error 500".

What do you think?

I will be happy to submit a pull request but I never written a line with golang...

thanks!
Davide

@tsenart
Copy link
Owner

tsenart commented Jan 3, 2015

That was indeed an oversight. Thanks for your diligence. https://github.com/tsenart/vegeta/releases/tag/v5.5.2

@davideicardi
Copy link
Author

Perfect! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants