Unclear documentation of vegeta.NewAttacker

[grobie]

// NewAttacker returns a pointer to a new Attacker
//
// redirects is the max amount of redirects the attacker will follow.
// timeout is the client side timeout for each request.
// addr is the local IP address used for each request.
// If nil, a local IP address is automatically chosen.
func NewAttacker(redirects int, timeout time.Duration, laddr net.IPAddr) *Attacker {

• the third parameter is called laddr
• it's not possible to pass nil

[grobie]

Thanks!

Is there a specific reason you use net.IPAddr{IP: net.IPv4zero} instead of net.IPAddr{} as DefaultLocalAddr? Seems to work as well and doesn't seem to limit it to IPv4, but I haven't tested the behavior on a IPv6 system.

p.s. s/addr/laddr/ in comment for consistency :p

[tsenart]

Using an empty net.IPAddr didn't event occurred to me. However, I don't see why the DefaultLocalAddr would limit you to IPv4. If you need to use IPv6, you can pass it in too.
I will test the empty net.IPAddr though as it may be more flexible indeed.

+1 for the consistency remark

[tsenart]

I will leave the DefaultLocalAddr to what it is currently. If you need to use a local IPv6 address, you can do it both with the library and the cli.

[clarlam]

I was wondering if it's possible to have laddr='::/0' and have that switch to net.IPv6zero ?

[tsenart]

@clarlam: Please open a bug issue if something isn't working for you.