-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move grammar to the official grammars repository #9
Comments
Hi, @KvanTTT ! |
I agree eventually this can be in the official antlr/grammars-v4 directory, but I'm not sure it's stable enough yet. For example, I have an unmerged branch tackling some When it gets to a stable state, I'll be fine with moving it to antlr/grammars-v4. |
This is not a big deal. A lot of grammars in the repository have a lack of support for some syntax.
In general, yes, but they have a lot of things in common. |
I'll tell you what. Let me scramble to get as much done of this by the end of Oct 1 (one month). There are things that bug me about the TODOs littered everywhere and the fact that there are tens of thousands of small individual test files that should be consolidated once this is more stable to avoid ballooning the size of antlr/grammars-v4. It's just a little rough around the edges, but it's getting there. I do want to finish this, but life has gotten in the way. |
Ok, sure, take your time. No rush anyway. |
I won't be able to finish this by Oct 1, but with the help @mebelousov we are making progress and I am committed to getting this done. I'm also coming around to @mebelousov's opinion above that this is easier to maintain as a standalone repository, especially as later versions of Postgres are also supported. |
I hope that we could be done with the parser by year's end. @tshprecher how about add some tags to the repository? Now antlr_psql is not included in search with "antlr4 postgresql" https://github.com/search?q=antlr4+postgresql |
Good idea, @mebelousov. I added the tags and now the repo shows up in that search. I think we can get this done by the end of the year. The major queries (SELECT, INSERT, UPDATE, and DELETE) have mostly been tackled. |
Hi! What do you think about adding your grammar to official grammars repository grammars-v4? We already have PL/SQL, T-SQL, MySQL. It would be easier to maintain and fix by the community. There is at least one request on it: antlr/grammars-v4#1501
The text was updated successfully, but these errors were encountered: