Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More helpful record_full_arg errors #2143

Closed
wants to merge 1 commit into from

Conversation

hyanwong
Copy link
Member

@hyanwong hyanwong commented Dec 8, 2022

There are a few cases (e.g. the DTWF) where full_arg recording is not possible. We should give slightly more informative error messages when this is attempted. This PR should make it easy to add extra error messages for different cases like this.

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #2143 (80a792f) into main (4e479ef) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2143   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files          19       19           
  Lines       11133    11136    +3     
  Branches     2266     2268    +2     
=======================================
+ Hits        10179    10182    +3     
  Misses        521      521           
  Partials      433      433           
Flag Coverage Δ
C 91.43% <100.00%> (+<0.01%) ⬆️
python 98.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
msprime/ancestry.py 99.11% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e479ef...80a792f. Read the comment docs.

@hyanwong hyanwong marked this pull request as draft December 8, 2022 14:05
Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - although this may be changing in the near future

Is it worth adding this now @GertjanBisschop?

@GertjanBisschop
Copy link
Member

This should change in the near future indeed (see #2132). If the next msprime release is 1.3.0, then there probably is not much of a point in merging this. If there is going to be an earlier release, then I am all for the (temporary) more meaningful error message.

@GertjanBisschop
Copy link
Member

Can be closed @hyanwong . Implemented in #2176.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants