auto_flush_edges #2183
Merged
auto_flush_edges #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2183 +/- ##
==========================================
+ Coverage 91.41% 91.46% +0.04%
==========================================
Files 20 20
Lines 11258 11253 -5
Branches 2298 2297 -1
==========================================
+ Hits 10291 10292 +1
+ Misses 526 523 -3
+ Partials 441 438 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
jeromekelleher
approved these changes
Jun 7, 2023
lib/msprime.c
Outdated
| const double *node_time = self->tables->nodes.time; | ||
|
|
||
| tsk_bug_assert(parent < (tsk_id_t) self->tables->nodes.num_rows); | ||
| if (self->num_buffered_edges > 0) { | ||
| last_edge = self->buffered_edges + self->num_buffered_edges - 1; |
There was a problem hiding this comment.
tsk_edge_t *edge, last_edge;
last_edge = self->buffered_edges [self->num_buffered_edges - 1]
if (last_edge.parent != parent) {
is a bit more efficient (and obvious I think - I don't know why I was so fond of pointer addition tricks in the old days!)
GertjanBisschop
force-pushed
the
auto_flush
branch
from
3dabb6b
to
9878a78
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2181 and #2182.
Note the
self->num_buffered_edges = 0;inmsp_reset(). When resetting the simulation there might be leftover edges in the buffer if the simulation ended with an error. This was the case fortest_demographic_events.