Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to stop people getting confused when inspecting ancestors tree sequences? #707

Open
hyanwong opened this issue Sep 21, 2022 · 1 comment
Milestone

Comments

@hyanwong
Copy link
Member

@szhan was inspecting his ancestors tree sequences, and getting understandably confused because e.g. it had a number of singletons (dues to the fact that the ancestors are marked as samples, so some of those ancestors have a unique allele). I can see other cases where the (necessary) oddity of having all the internal nodes marked as samples will confuse people. Is there any obvious way to flag this up programmatically to avoid confusion? I can't think of anything obvious, to be honest - there's (deliberately?) no detectable difference between a normal tree sequence and an ancestors tree sequence, right? I seem to recall there were good reasons not to e.g. make an ancestors TS a derived python class with some slightly different methods.

@jeromekelleher
Copy link
Member

That would be quite hard. Perhaps the simplest thing would be to add some top-level metadata saying this, which gets displayed when people view it as print(ts) or in a notebook?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants