-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set keep_unary on simplify, and document (including path compression docs) #176
Set keep_unary on simplify, and document (including path compression docs) #176
Conversation
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
==========================================
+ Coverage 93.93% 93.93% +<.01%
==========================================
Files 11 11
Lines 2885 2886 +1
Branches 507 507
==========================================
+ Hits 2710 2711 +1
Misses 145 145
Partials 30 30
Continue to review full report at Codecov.
|
@jeromekelleher - do we want to document the
And (weirdly to me), the |
No, this is too complicated, will probably change over time and is really for internal use. We don't want people using this.
That is weird --- we should change the signature of the function to match the docs. |
Fine. I'll do this in the same PR shall I? We don't mind changing the order in this case? I guess we put it either before or after the (similarly an correctly undocumented) |
That would be good, thanks. |
1fea866
to
2dbac3a
Compare
This now works and passes unit tests on my machine, but since |
7c99bdc
to
a62c6d4
Compare
tskit 0.2.0 should be shipped in a week or so --- best to wait for it to avoid complications. |
Right - perfect. Thanks. |
1499e4d
to
badd08c
Compare
Closes #146 |
badd08c
to
899ebf5
Compare
We should also switch
simplify
in these cases to setkeep_unary=True
, and document accordingly.