Replace most refs to msprime to refer to tskit #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
=======================================
Coverage 93.93% 93.93%
=======================================
Files 11 11
Lines 2885 2885
Branches 507 507
=======================================
Hits 2710 2710
Misses 145 145
Partials 30 30Continue to review full report at Codecov.
|
docs/installation.rst
Outdated
| +++++++++++++++++++++ | ||
|
|
||
|
|
||
| There are situations (usually where the GSL libraries are not in the |
There was a problem hiding this comment.
We shouldn't be installing msprime at all now though, right? So, GSL shouldn't come into it at all.
|
Looks good, thanks. There should be no reference to msprime in the code any more though, so we shouldn't pull it in during install. |
|
Ah, I assumed tskit used GSL too. If not, I'll simply remove this bit of "Installation problems". OK? |
jeromekelleher
force-pushed
the
doc-URL-corrections
branch
from
5feccdd
to
1993a92
Compare
And add @brianzhang01 's installation problems. Fixes tskit-dev#177
|
Merging, thanks @hyanwong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add @brianzhang01 's installation problems. Fixes #177