Switch to the (more correct) new map_mutations code #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyanwong
force-pushed
the
new-map-mutations
branch
4 times, most recently
from
960c7f0
to
64195a4
Compare
This allows ancestral states to be correctly set, but will only be valid once a version of tskit > 0.3.6 is released.
hyanwong
force-pushed
the
new-map-mutations
branch
from
64195a4
to
0242c6c
Compare
Codecov Report
@@ Coverage Diff @@
## main #557 +/- ##
==========================================
+ Coverage 93.05% 93.08% +0.03%
==========================================
Files 17 17
Lines 5124 5119 -5
Branches 934 931 -3
==========================================
- Hits 4768 4765 -3
+ Misses 233 232 -1
+ Partials 123 122 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows ancestral states to be correctly set, but will only work once a version of tskit > 0.3.6 is released with PR tskit-dev/tskit#1550 merged