Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsimoniously explain direct reversions #776

Conversation

jeromekelleher
Copy link
Member

Insert a new node to avoid A->B->A mutation transitions along inheritance paths.

Insert a new node to avoid A->B->A mutation transitions along
inheritance paths.
@jeromekelleher jeromekelleher marked this pull request as draft November 10, 2022 14:15
@hyanwong
Copy link
Member

Does this happen along a single (non-bifurcating) chain of edges. That would seem weird.

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #776 (5bf801a) into main (19ce791) will increase coverage by 0.04%.
The diff coverage is 97.00%.

@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
+ Coverage   93.55%   93.59%   +0.04%     
==========================================
  Files          17       17              
  Lines        5538     5622      +84     
  Branches     1019     1042      +23     
==========================================
+ Hits         5181     5262      +81     
- Misses        235      237       +2     
- Partials      122      123       +1     
Flag Coverage Δ
C 93.59% <97.00%> (+0.04%) ⬆️
python 96.68% <97.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tsinfer/constants.py 100.00% <ø> (ø)
tsinfer/inference.py 98.62% <97.00%> (-0.18%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jeromekelleher
Copy link
Member Author

Happens quite a lot when you have sequences that are sampled close together in time, and you happen to sample one that has an extra mutation a day earlier.

@jeromekelleher jeromekelleher deleted the immediate-reversions-parsimony branch January 11, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants