Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need marker traits for metadata. #157

Closed
molpopgen opened this issue Aug 27, 2021 · 1 comment · Fixed by #158
Closed

Need marker traits for metadata. #157

molpopgen opened this issue Aug 27, 2021 · 1 comment · Fixed by #158

Comments

@molpopgen
Copy link
Member

Currently, a single trait defines metadata. This leads to a potential problem for external APIs writing "export to tskit" functions. One could send the wrong metadata to the wrong table.

Since all metadata need the same API, then a simple set of marker traits will suffice to distinguish Node from Individual metadata, etc..
@molpopgen
Copy link
Member Author

simple set of marker traits will suffice to distinguish Node from Individual metadata, etc..

This is harder than it sounds.

@molpopgen molpopgen linked a pull request Aug 27, 2021 that will close this issue
Add marker traits for table-specific metadata. #158
Merged
molpopgen added a commit that referenced this issue Aug 29, 2021
@molpopgen
Refactor metadata encoding:
734d93f 
* Add per-table metadata trait marker.
* Remove use of Option<metadata> from the API

Closes #157
molpopgen added a commit that referenced this issue Aug 29, 2021
@molpopgen
Refactor metadata encoding: (#158)
fafd457 
* Add per-table metadata trait marker.
* Remove use of Option<metadata> from the API

Closes #157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add marker traits for table-specific metadata. tskit-dev/tskit-rust
1 participant
@molpopgen