You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following the discussion in #1339, we should change the signature of Tree.mrca to accept two or more nodes. The initial implementation can be something like
defmrca(self, *args):
iflen(args) <2:
raiseValueError("Must supply at least two arguments")
returnfunctools.reduce(self._ll_tree.mrca, args)
We're not going to break anyone's code by doing this, and it's an obvious generalisation. We can make a more performant implementation in the future if we like, but this'll do fine for now.
The text was updated successfully, but these errors were encountered:
This would be useful to find the MRCA of all samples in the tree (which could be different from the root if there are unary nodes above the grand MRCA). Would it be much slower than looking at the root and descending until we find a non-unary node, though?
Following the discussion in #1339, we should change the signature of Tree.mrca to accept two or more nodes. The initial implementation can be something like
We're not going to break anyone's code by doing this, and it's an obvious generalisation. We can make a more performant implementation in the future if we like, but this'll do fine for now.
The text was updated successfully, but these errors were encountered: