New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add num_children Python #2332
add num_children Python #2332
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2332 +/- ##
==========================================
+ Coverage 93.28% 93.29% +0.01%
==========================================
Files 28 28
Lines 26722 26730 +8
Branches 1222 1222
==========================================
+ Hits 24927 24939 +12
+ Misses 1762 1758 -4
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The UINT64 thing raises an important question, which I've opened #2333 to discuss.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we might want to add num_children to data-model.md
as that documents the other arrays?
Also might be nice to simplify things like test_topology:239
I think num_children
needs to be added at test_topology:1793,1825,1880,1914,2185,6482
Also, a changelog would be appreciated! |
Had a go at adding in some documentation on the |
Once #2337 is merged we can modify this PR to return the 32bit type. |
9db2034
to
a618a3a
Compare
@jeromekelleher I've added a commit here to convert to int32. Would you do a quick sanity review of that before we merge here? |
a618a3a
to
70d7e1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
First pass at low level Python for
tree.num_children_array
and Python API. Was mostly copy and paste as expected, but still second-guessing myself I might have missed something.I have set the type of the
num_children_array
toUINT64
(seetsk_size_t
). Hope this is the correct 'translation'.