Fix draw_svg warning for mutations above unplotted nodes #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2871 +/- ##
==========================================
- Coverage 89.69% 89.69% -0.01%
==========================================
Files 30 30
Lines 30160 30159 -1
Branches 5860 5860
==========================================
- Hits 27053 27052 -1
Misses 1778 1778
Partials 1329 1329
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
benjeffery
reviewed
Nov 15, 2023
There was a problem hiding this comment.
Generally in the test we're using pytest.warns as it's a bit cleaner and lets you check the message: https://happytest.readthedocs.io/en/latest/warnings/#warns
|
Yep lgtm |
duncanMR
force-pushed
the
fix_plot_warning
branch
from
33b842f
to
90c4207
Compare
|
I've switched the tests to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2870.
I changed the warning module and modified all the tests that raised that warning to catch it correctly. I made the stack level 2 simply because that seemed to be common with
UserWarninginstances elsewhere in the package; I'm not sure how one determines that here.PR Checklist: