Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default expansion behaviour for tables to doubling #5

Closed
jeromekelleher opened this issue Jan 8, 2019 · 0 comments · Fixed by #1683
Closed

Change default expansion behaviour for tables to doubling #5

jeromekelleher opened this issue Jan 8, 2019 · 0 comments · Fixed by #1683
Labels
C API Issue is about the C API enhancement New feature or request
Milestone

Comments

@jeromekelleher
Copy link
Member

The C tables currently have a mechanism for incrementing the available size using a constant value. The default is to expand with a fixed size of 1024 rows. This should be changed to default to doubling on demand as follows: if the max_rows_increment value is 0, we double the number of rows (or increase the size to the requested, whichever is larger). This should be efficient in most cases, and also give good flexibility for those who want to tightly control memory usage and realloc behaviour.

@jeromekelleher jeromekelleher added enhancement New feature or request C API Issue is about the C API labels Jan 8, 2019
@benjeffery benjeffery added this to the C Upcoming milestone Nov 20, 2020
@mergify mergify bot closed this as completed in #1683 Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C API Issue is about the C API enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants