Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use individual tables when writing out vcf files #73

Closed
petrelharp opened this issue Jul 2, 2018 · 6 comments
Closed

use individual tables when writing out vcf files #73

petrelharp opened this issue Jul 2, 2018 · 6 comments

Comments

@petrelharp
Copy link
Contributor

Currently write_vcf has a ploidy argument, and will assume that adjacent samples belong to the same individual. This should be deprecated after we provide a make_individuals method, and write_vcf should have an argument that toggles whether to write individuals or genomes (maybe: output either monoploid by default or phased or `unphased).

@jeromekelleher
Copy link
Member

This will take a bit more time than I have right now, so kicking it down the road to 0.6.2.

@jeromekelleher jeromekelleher transferred this issue from tskit-dev/msprime Jan 11, 2019
@petrelharp
Copy link
Contributor Author

Also we should have an option to output a diploid genotype matrix, summing together the rows of genotype matrix for the given individuals' nodes.

@jeromekelleher
Copy link
Member

Also we should have an option to output a diploid genotype matrix, summing together the rows of genotype matrix for the given individuals' nodes.

So we output unphased "dosage" values?

@petrelharp
Copy link
Contributor Author

So we output unphased "dosage" values?

Right. Well, we should output diploid genotypes based on individuals in a way that works well with scikit-allel.

@jeromekelleher
Copy link
Member

I'm going to close this after #73 is merged as this uses the individual table to generate the diploid/whateverploid individuals. We should open more specific issues for the other stuff raised here if we want them.

@jeromekelleher
Copy link
Member

Closed in #286.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants