Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'to_nexus()' emits basically compliant Nexus #1835

Merged
merged 1 commit into from Oct 22, 2021

Conversation

jeetsukumaran
Copy link
Contributor

Description

Thanks for contributing to tskit! ❤️
A guide to the PR process is here
Please replace this text with a summary of the change and which issue is fixed, if any. Please also include relevant motivation and context.

Fixes #(issue) <- Putting the issue number here will auto-close the issue when this PR is merged

PR Checklist:

  • Tests that fully cover new/changed functionality.
  • Documentation including tutorial content if appropriate.
  • Changelogs, if there are API changes.

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #1835 (c92329c) into main (6b4d127) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1835   +/-   ##
=======================================
  Coverage   93.43%   93.43%           
=======================================
  Files          27       27           
  Lines       24803    24804    +1     
  Branches     1094     1094           
=======================================
+ Hits        23174    23175    +1     
  Misses       1594     1594           
  Partials       35       35           
Flag Coverage Δ
c-tests 92.20% <ø> (ø)
lwt-tests 89.14% <ø> (ø)
python-c-tests 94.53% <100.00%> (+<0.01%) ⬆️
python-tests 98.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/trees.py 97.84% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b4d127...c92329c. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @jeetsukumaran! I'll follow up with a PR to add dendropy based testing.

@jeromekelleher jeromekelleher added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Oct 22, 2021
@mergify mergify bot merged commit 631ed78 into tskit-dev:main Oct 22, 2021
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants