Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement tskit treeseq from text mutations #2734

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lukashuebner
Copy link

Fixes #2729

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #2734 (5437546) into main (72a7add) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2734   +/-   ##
=======================================
  Coverage   94.08%   94.08%           
=======================================
  Files          29       29           
  Lines       28516    28516           
  Branches     1609     1609           
=======================================
  Hits        26828    26828           
  Misses       1653     1653           
  Partials       35       35           
Flag Coverage Δ
c-tests 92.36% <ø> (ø)
lwt-tests 89.05% <ø> (ø)
python-c-tests 70.89% <ø> (ø)
python-tests 99.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72a7add...5437546. Read the comment docs.

@jeromekelleher
Copy link
Member

Thanks for this @lukashuebner - I think @petrelharp has done basically the same thing in #2730. See the discussion over there for why we're a bit nervous about always computing the parents like this.

@petrelharp
Copy link
Contributor

Yes, thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nasty gotcha in the AFS calculation
3 participants