Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix height scaling issue in TreeSequence.draw_svg. #378

Merged
merged 1 commit into from Nov 20, 2019

Conversation

jeromekelleher
Copy link
Member

Closes #319.

cc @gtsambos

@gtsambos
Copy link
Member

gtsambos commented Oct 5, 2019

Sorry I didn't get around to this quickly - thanks @jeromekelleher!

@jeromekelleher
Copy link
Member Author

The fix works, but tests fail because of another bug. When #383 is fixed, we can rebase this and merge.

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #378 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   86.59%   86.59%           
=======================================
  Files          20       20           
  Lines       14139    14139           
  Branches     2756     2756           
=======================================
  Hits        12244    12244           
  Misses        977      977           
  Partials      918      918
Flag Coverage Δ
#c_tests 87.71% <ø> (ø) ⬆️
#python_c_tests 90.49% <ø> (ø) ⬆️
#python_tests 99.3% <ø> (?)
Impacted Files Coverage Δ
python/tskit/drawing.py 99.63% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a6ef7f...a3c19ce. Read the comment docs.

@jeromekelleher jeromekelleher merged commit cb454e6 into tskit-dev:master Nov 20, 2019
@jeromekelleher jeromekelleher deleted the fix-svg-trees branch November 20, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

draw_svg() doesn't scale tree heights by time correctly
2 participants