fix(MassEdit) Moving the preg_replace out of the loop

tsolucio · Aug 4, 2018 · 9e611ef · 9e611ef
1 parent c8999d2
commit 9e611ef
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/modules/Vtiger/MassEditSave.php b/modules/Vtiger/MassEditSave.php
@@ -43,6 +43,10 @@ function send_message($id, $message, $progress, $processed, $total) {
 $exists = executefunctionsvalidate('ValidationExists', $currentModule);
 if (isset($idlist)) {
 	$_REQUEST['action'] = 'MassEditSave';
+
+	// Replacing params action value
+	$_REQUEST['params'] = preg_replace('/"action":""/', '"action":"MassEditSave"', $_REQUEST['params']);
+
 	$recordids = explode(';', $idlist);
 	$recordcount = count($recordids)-1;
 	$id = 1;
@@ -84,9 +88,6 @@ function send_message($id, $message, $progress, $processed, $total) {
 			list($saveerror,$errormessage,$error_action,$returnvalues) = $focus->preSaveCheck($params);
 			if (!$saveerror) { // if there is an error we ignore this record
 				if ($exists == 'yes') {
-					// Replacing action value
-					$_REQUEST['params'] = preg_replace('/"action":""/', '"action":"MassEditSave"', $_REQUEST['params']);
-
 					$validation = executefunctionsvalidate('ValidationLoad', $currentModule, vtlib_purify($_REQUEST['params']));
 					if ($validation == '%%%OK%%%') {
 						$msg = $app_strings['record'].' '.$recordid.' '.$app_strings['saved'];