Kubernetes: apps with binded volumes can't change namespaces #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrestc
requested changes
Oct 10, 2018
There was a problem hiding this comment.
Looks good but I think there is missing step when moving apps accross different clusters: removing the volume claim and the volume on the old cluster.
I think both should be done on the provisioner.Destroy(app) method (which is called for the old app once it was migrated). The PVC should always be removed but the volume should only be removed if there isn't another app bound to it.
Deleting the volume should only be done if there is no other application bound to the volume.
…ce of the same cluster
…p volumes with more binded apps
ggarnier
force-pushed
the
kube-update-volume
branch
from
164aba7
to
e2b6384
Compare
|
@andrestc PTAL |
andrestc
approved these changes
Oct 24, 2018
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't support moving volumes between namespaces of a Kubernetes cluster. This PR adds a validation to prevent this.
Moving between different clusters works fine.