Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addComments feature (or docs) #105

Closed
opyh opened this issue Aug 8, 2018 · 2 comments
Closed

Fix addComments feature (or docs) #105

opyh opened this issue Aug 8, 2018 · 2 comments
Assignees

Comments

@opyh
Copy link

opyh commented Aug 8, 2018

The addComments config parameter seems not to work anymore in 1.1.0-0 (or the documentation is outdated).

When specifying addComments: 'translator:' as config option, the following comment will not be added to the .pot file: // translator: Bla. This is because the configured prefix needs to include the whitespace between // and translator. From my memory, this has worked before, and the documentation says it's supposed to work without specifying the space.

I'm using addComments: ' translator:' (note the space at the beginning of the string) as a workaround for now. Should we just update the docs and add the string there, or support whitespace in the matcher?

Thanks to everyone putting effort into maintaining this project, you rock! 👌🏻

@AlexMost
Copy link
Member

AlexMost commented Aug 8, 2018

Hey, thanks for the feedback! ❤️
I think that is a bug, and we should omit spaces after // while matching. That one should be easy to fix.

@AlexMost
Copy link
Member

AlexMost commented Aug 8, 2018

version 1.1.0 is available with fix

@AlexMost AlexMost closed this as completed Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants