-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fssm 0.2.7 fails tests with rb-inotify 0.8.6 installed #30
Comments
known, and not just rb-inotify. :-/ I got sidetracked with work on rb-fsevent, but started a cleanup of FSSM that lead to starting a rewrite which hasn't been pushed to a public repo yet. Anyways, the relevant line from the cleanup branch: https://github.com/ttilley/fssm/blob/cleanup/spec/monitor_spec.rb#L136 |
Thanks for the feedback. I've applied that patch in Gentoo and made the fssm package depend on rb-inotify, so that people will now automatically get the inotify support. |
If that's the case, there are probably other commits on the cleanup branch you'd want to consider. SHA: fbe274b Note that the statements about rb-inotify only passing the test suite in JRuby no longer apply with the latest release of rb-inotify. |
I'm making use of bundler to provide proper platform support when running rake and specs, which you don't care about in gentoo since you obviously only need the inotify backend. |
We try to stay as close as possible to the upstream releases, so I'm going to pass on the additional commits. In Gentoo we offer our users the ability to runs tests automatically when installing, so I needed to apply that patch to get a passing test suite. Also note that Gentoo can and does run on other kernels, e.g. on macos or even Windows, so we can't fully assume inotify-only. But we can't use bundler to install things either, so we need to solve all the dependency fun on our end anyway. |
This is with ruby 1.8.7 (2011-02-18 patchlevel 334) [x86_64-linux] on a Gentoo Linux machine. Please let me know if you need more information to track this down. Without rb-inotify all specs pass.
The text was updated successfully, but these errors were encountered: