Change encoder type on button press

[Maikele1]

Hello,
I am working on a Trim/Fader unit for channel 7 on my Sound Devices 833 unit.
The idea is that using 1 encoder can control both trim and fader by double pressing on the switch

The problem I'm having is that Trim uses CCRotaryEncoder and Fade uses PBAbsoluteEncoder and using MultiplePurpose button I can't get it to toggle between the two. resulting in no midi signal being sent at all.

// https://github.com/tttapa/Control-Surface
#include <Encoder.h> // Include the Encoder library.
#include <Control_Surface.h> // Include the Control Surface library
#include <Arduino_Helpers.h>
#include <AH/Hardware/MultiPurposeButton.hpp>


// Instantiate a MIDI over USB interface.
USBMIDI_Interface midi;


// Trim
CCAbsoluteEncoder absoluteEncoder1 {
  {2, 3},
  MCU::V_POT_7,
  1,
};

// Fader
PBAbsoluteEncoder rotaryEncoder1 {
  {2, 3},
  Channel_7,
  1,
};


MultiPurposeButton btn{6};


int encoder1Status = 0; //  0 = Rotary, 1 = Absolute


void setup() {
  Serial.begin(115200);
  btn.setLongPressDelay(1000);
  btn.setMultiPressDelay(400);
  btn.begin();
  
  // Select the correct relative MIDI CC mode:
  RelativeCCSender::setMode(relativeCCmode::MACKIE_CONTROL_RELATIVE);
  Control_Surface.begin(); // Initialize Control Surface

  absoluteEncoder1.disable(); // Default state
  rotaryEncoder1.enable(); // Default state

void loop() {
  auto longPressTime = btn.getLongPressedTime();
  switch (btn.update()) {
    case btn.None: break;
    case btn.LongPress:
      if(encoder1Status == 0) {
        rotaryEncoder1.disable();
        absoluteEncoder1.enable(); 
        encoder1Status = 1;
      } else {
        absoluteEncoder1.disable();
        rotaryEncoder1.enable();
        encoder1Status = 0;
      }
      break;
  }

  Control_Surface.loop(); // Update the Control Surface
}

[tttapa]

The problem is that you cannot have two encoders on the same pins. The solution is to create a single encoder object separately, and then share it between the different MIDI encoder objects:

#include <Control_Surface.h> // https://github.com/tttapa/Control-Surface
#include <AH/Hardware/MultiPurposeButton.hpp>

// Instantiate a MIDI over USB interface.
USBMIDI_Interface midi;

AHEncoder enc{2, 3};

// Trim
BorrowedMIDIAbsoluteEncoder<ContinuousCCSender> cc_enc {
  enc,
  MCU::V_POT_7,
  1, 4, {},
};

// Fader
BorrowedMIDIAbsoluteEncoder<PitchBendSender<10>> pb_enc {
  enc,
  Channel_7,
  1, 4, {},
};

MultiPurposeButton btn{6};
enum class EncoderMode {
  PitchBend, ControlChange
} mode = EncoderMode::PitchBend;

void setup() {
  Serial.begin(115200);
  btn.setLongPressDelay(1000);
  btn.setMultiPressDelay(400);
  btn.begin();

  // Disable the second encoder before calling Control_Surface.begin(),
  // so the encoder doesn't get initialized twice:
  cc_enc.disable(); // Default state
  
  Control_Surface.begin(); // Initialize Control Surface
}

void loop() {
  switch (btn.update()) {
    case btn.None: break;
    case btn.LongPress:
      if(mode == EncoderMode::PitchBend) {
        Serial.println("cc");
        pb_enc.disable();
        cc_enc.resetPositionOffset();
        cc_enc.enable();
        mode = EncoderMode::ControlChange;
      } else {
        Serial.println("pb");
        cc_enc.disable();
        pb_enc.resetPositionOffset();
        pb_enc.enable();
        mode = EncoderMode::PitchBend;
      }
      break;
  }

  Control_Surface.loop(); // Update the Control Surface
}

Also note the calls to resetPositionOffset(). Without those, you'd see jumps when switching modes.

[Maikele1]

That does indeed work, thanks! Only V_POT_7 using the full midi range (127) when being rotated

This way the mixer acts very jittery

Previously it showed this on the midi monitor (this is also how it supposed to work in the mixer)

Sorry if i'm overlooking something very obvious. I'm quite new to this

[tttapa]

In that case, you should use RelativeCCSender instead of ContinuousCCSender, and add the RelativeCCSender::setMode(relativeCCmode::MACKIE_CONTROL_RELATIVE); to your setup again.