Fix compilation of exploration_planner and path_follower #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -317,15 +317,15 @@ namespace pose_follower { | |||
| transformed_plan.clear(); | |||
|
|
|||
| try{ | |||
| if (!global_plan.size() > 0) | |||
| if (!(global_plan.size() > 0)) | |||
There was a problem hiding this comment.
This was definitely a bug, even if in this special case the implicit conversion from the boolean expression !global_plan.size() to an integer (which is 0 or 1) leads to the same result when compared against 0 as the intended expression.
Even better:
if (global_plan.empty())
{
// ...
}
|
Thank you very much! This patch looks good to me. |
spmaniato
force-pushed
the
fix_compilation
branch
from
4faefff
to
b7e878a
Compare
spmaniato
force-pushed
the
fix_compilation
branch
from
b7e878a
to
2d68997
Compare
|
Just a heads-up that I've updated the PR based on Johannes' feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue mentioned in #5 and also a clang compiler warning that indeed looks like a bug (hector_path_follower.cpp L320)
Compilation after applying this patch has been tested under ROS Indigo on both Ubuntu 14.04.x and OS X El Capitan. I also ran the exploration functionality on Ubuntu. Looks good.