Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DELETE ME - Feature #623 channel audio mode #628

Conversation

greg321321
Copy link
Contributor

@greg321321 greg321321 commented Dec 10, 2023

Issue #623

Works ok with AntennaPod and PodcastAddict Android apps.

Ready for review.

@greg321321 greg321321 marked this pull request as draft December 10, 2023 01:25
@greg321321 greg321321 marked this pull request as ready for review December 10, 2023 13:55
@bbilly1
Copy link
Member

bbilly1 commented Jan 27, 2024

OK, sorry I'm a bit slow at the moment. Plan is:

Thanks for your patience.

@Boo1098
Copy link
Contributor

Boo1098 commented Apr 27, 2024

Haven't gotten a chance to find why, but when running your branch I found that I could get the .rss file to download after removing the auth/token from the url. This was in a new private browser window so it appears it is not checking for a token at all. When I left the auth/token in the url, I got a 502 error with no logs indicating why.

@greg321321
Copy link
Contributor Author

Haven't gotten a chance to find why, but when running your branch I found that I could get the .rss file to download after removing the auth/token from the url. This was in a new private browser window so it appears it is not checking for a token at all. When I left the auth/token in the url, I got a 502 error with no logs indicating why.

will look at it.

@bbilly1
Copy link
Member

bbilly1 commented May 9, 2024

Thanks for your patience. I've made good progress with the scheduler migration. Please rebase upstream testing branch, then we can look into this next.

@greg321321
Copy link
Contributor Author

ok, there is one additonal fix I will put in regarding a safeguard against too many requests to content interface. AirPod app requests 100 video files at a time if that is what is in it's download queue. This makes TA slow and unable to respond to all requests, including user requests on the TA UI.

@bbilly1
Copy link
Member

bbilly1 commented Jun 6, 2024

OK, if you are still up for this, there is a short window of opportunity. I want to refactor things soon to get started on the new frontend, maybe in a week or two. That will further deviate from current state, making merging unfeasible.

So we'll have to wrap this up before then, otherwise we can take another stab at this at a later point in time.

@greg321321
Copy link
Contributor Author

ok sounds good. I have time this weekend to issue updated pull request.

@greg321321
Copy link
Contributor Author

synced changes with testing branch, but "Files changed" tab doesn't show the latest testing branch changes. Should I delete this pull request and re-issue it?

@bbilly1
Copy link
Member

bbilly1 commented Jun 12, 2024

Yes, feel free to reopen.

You'll have to merge testing branch into your branch and resolve the conflicts.

@greg321321 greg321321 changed the title Feature #623 channel audio mode DELETE ME - Feature #623 channel audio mode Jun 13, 2024
@greg321321
Copy link
Contributor Author

I am issuing a new pull request for this feature. delete this pull request.

@greg321321 greg321321 closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants