Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is no Semantic Surface Object, should it be {} or null #8

Closed
hugoledoux opened this issue Oct 10, 2017 · 4 comments
Closed

is no Semantic Surface Object, should it be {} or null #8

hugoledoux opened this issue Oct 10, 2017 · 4 comments

Comments

@hugoledoux
Copy link
Member

"semantics": [
      {
        "type": "RoofSurface",
        "slope": 16.4,
        "solar-potential": 5
      },
      {},
      {
        "type": "GroundSurface"
      }
    ]

or null instead? Or both?

@clausnagel
Copy link
Contributor

Only null in my opinion.

@kenohori
Copy link
Member

I agree, null seems best.

@hugoledoux
Copy link
Member Author

hugoledoux commented Oct 12, 2017 via email

@hugoledoux
Copy link
Member Author

no necessary anymore, from v0.5 the Semantic Surface are enumerated and links to them provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants