Lowercase all input to be more flexible when calling test/build (#6268)

tuist · May 21, 2024 · de6dcba · de6dcba
1 parent a647f6f
commit de6dcba
Show file tree

Hide file tree

Showing 4 changed files with 59 additions and 6 deletions.
diff --git a/Sources/TuistGraph/Models/Platform.swift b/Sources/TuistGraph/Models/Platform.swift
@@ -1,4 +1,14 @@
 import Foundation
+import TuistSupport
+
+struct UnsupportedPlatformError: FatalError, CustomStringConvertible, Equatable {
+    let type: TuistSupport.ErrorType = .abort
+
+    let input: String
+    var description: String {
+        "Specified platform \(input) does not map to any of these supported platforms: \(Platform.allCases.map(\.caseValue).joined(separator: ", ")) "
+    }
+}
 
 public enum Platform: String, CaseIterable, Codable, Comparable {
     case iOS = "ios"
@@ -17,6 +27,17 @@ public enum Platform: String, CaseIterable, Codable, Comparable {
         }
     }
 
+    init?(commandLineValue: String) {
+        self.init(rawValue: commandLineValue.lowercased())
+    }
+
+    public static func from(commandLineValue: String) throws -> Platform {
+        guard let platform = Platform(rawValue: commandLineValue.lowercased()) else {
+            throw UnsupportedPlatformError(input: commandLineValue)
+        }
+        return platform
+    }
+
     public static func < (lhs: Platform, rhs: Platform) -> Bool {
         lhs.rawValue < rhs.rawValue
     }

diff --git a/Sources/TuistKit/Services/BuildService.swift b/Sources/TuistKit/Services/BuildService.swift
@@ -110,8 +110,8 @@ public final class BuildService {
 
             let buildPlatform: TuistGraph.Platform
 
-            if let platform, let inputPlatform = TuistGraph.Platform(rawValue: platform) {
-                buildPlatform = inputPlatform
+            if let platform {
+                buildPlatform = try TuistGraph.Platform.from(commandLineValue: platform)
             } else {
                 buildPlatform = try graphTarget.target.servicePlatform
             }
@@ -141,8 +141,8 @@ public final class BuildService {
 
                 let buildPlatform: TuistGraph.Platform
 
-                if let platform, let inputPlatform = TuistGraph.Platform(rawValue: platform) {
-                    buildPlatform = inputPlatform
+                if let platform {
+                    buildPlatform = try TuistGraph.Platform.from(commandLineValue: platform)
                 } else {
                     buildPlatform = try graphTarget.target.servicePlatform
                 }

diff --git a/Sources/TuistKit/Services/TestService.swift b/Sources/TuistKit/Services/TestService.swift
@@ -338,8 +338,8 @@ public final class TestService { // swiftlint:disable:this type_body_length
 
         let buildPlatform: TuistGraph.Platform
 
-        if let platform, let inputPlatform = TuistGraph.Platform(rawValue: platform) {
-            buildPlatform = inputPlatform
+        if let platform {
+            buildPlatform = try TuistGraph.Platform.from(commandLineValue: platform)
         } else {
             buildPlatform = try buildableTarget.target.servicePlatform
         }

diff --git a/Tests/TuistGraphTests/Models/PlatformTests.swift b/Tests/TuistGraphTests/Models/PlatformTests.swift
@@ -19,6 +19,38 @@ final class PlatformTests: XCTestCase {
         XCTAssertCodable(subject)
     }
 
+    func test_caseInsensitiveCommandInput() {
+        XCTAssertEqual(Platform.macOS, Platform(commandLineValue: "macos"))
+        XCTAssertEqual(Platform.macOS, Platform(commandLineValue: "macOS"))
+        XCTAssertEqual(Platform.macOS, Platform(commandLineValue: "MACOS"))
+        XCTAssertEqual(Platform.iOS, Platform(commandLineValue: "ios"))
+        XCTAssertEqual(Platform.iOS, Platform(commandLineValue: "iOS"))
+        XCTAssertEqual(Platform.iOS, Platform(commandLineValue: "IOS"))
+        XCTAssertEqual(Platform.tvOS, Platform(commandLineValue: "tvos"))
+        XCTAssertEqual(Platform.tvOS, Platform(commandLineValue: "tvOS"))
+        XCTAssertEqual(Platform.watchOS, Platform(commandLineValue: "watchos"))
+        XCTAssertEqual(Platform.watchOS, Platform(commandLineValue: "watchOS"))
+        XCTAssertEqual(Platform.visionOS, Platform(commandLineValue: "visionos"))
+        XCTAssertEqual(Platform.visionOS, Platform(commandLineValue: "visionOS"))
+    }
+
+    func test_caseInvalidPlatform_throws() {
+        do {
+            let _ = try Platform.from(commandLineValue: "not_a_platform")
+            XCTFail("Expected erro to be thrown")
+        } catch let error as UnsupportedPlatformError {
+            XCTAssertEqual(error, UnsupportedPlatformError(input: "not_a_platform"))
+        } catch {
+            XCTFail("Unexpected error thrown")
+        }
+    }
+
+    func test_caseValidPlatform_doesNotThrow() throws {
+        XCTAssertEqual(Platform.iOS, try Platform.from(commandLineValue: "iOS"))
+        XCTAssertEqual(Platform.macOS, try Platform.from(commandLineValue: "macOS"))
+        XCTAssertEqual(Platform.macOS, try Platform.from(commandLineValue: "macos"))
+    }
+
     func test_xcodeSdkRoot_returns_the_right_value() {
         XCTAssertEqual(Platform.macOS.xcodeSdkRoot, "macosx")
         XCTAssertEqual(Platform.iOS.xcodeSdkRoot, "iphoneos")