Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1065 update docs and add conformance to ExpressibleByStringInterpolation #1081

Merged
merged 3 commits into from
Mar 10, 2020
Merged

Issue 1065 update docs and add conformance to ExpressibleByStringInterpolation #1081

merged 3 commits into from
Mar 10, 2020

Conversation

chojnac
Copy link
Contributor

@chojnac chojnac commented Mar 9, 2020

Resolves #1065 #1064

Short description 📝

This PR fixes 2 issues:

  1. Fix missing value name reported in the issue Incorrect documentation #1065
  2. Fix compilation errors in the same example (Project+Templates.swift) Failure to pass interpolated string to InfoPlist, SourceFilesGlob, FileElement #1064

Solution 📦

The problem with compilation errors is caused by using string interpolation with types InfoPlist, SourceFileGlob and FileElement which only implements ExpressibleByStringLiteral.
The solution is to add for these types conformance to ExpressibleByStringInterpolation protocol.

Implementation 👩‍💻👨‍💻

  • Add conformance to ExpressibleByStringInterpolation for selected types
  • Add missing value name in the example code

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #1081 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1081   +/-   ##
=======================================
  Coverage   78.84%   78.84%           
=======================================
  Files         238      238           
  Lines       11346    11346           
=======================================
  Hits         8946     8946           
  Misses       2400     2400
Impacted Files Coverage Δ
Sources/ProjectDescription/SourceFilesList.swift 62.85% <ø> (ø) ⬆️
Sources/ProjectDescription/Path.swift 100% <ø> (ø) ⬆️
Sources/ProjectDescription/FileElement.swift 88.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e2a116...8412f10. Read the comment docs.

Copy link
Contributor

@pepicrft pepicrft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @chojnac. Would you mind adding an entry to the CHANGELOG? We can merge afterwards.

@chojnac
Copy link
Contributor Author

chojnac commented Mar 9, 2020

Thanks for fixing this @chojnac. Would you mind adding an entry to the CHANGELOG? We can merge afterwards.

done

@pepicrft pepicrft merged commit 55b307a into tuist:master Mar 10, 2020
@chojnac chojnac deleted the issue_1065-update-doc branch March 10, 2020 12:05
@chojnac chojnac restored the issue_1065-update-doc branch March 15, 2020 21:15
@chojnac chojnac deleted the issue_1065-update-doc branch March 15, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect documentation
2 participants