Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a tests file #1172

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Generate a tests file #1172

merged 2 commits into from
Mar 31, 2020

Conversation

pepicrft
Copy link
Contributor

Short description 📝

I recently changed the template that gets generated with tuist init so that it leverages the helpers that are generated. Those helpers define for each framework 2 targets, one with the source, and the other one with the tests.
Since I forgot to update the template to generate a tests file, running tuist generate on the project scaffolded with tuist scaffold framework MyFramework results in warnings because the tests target contains no files.

This PR fixes that by extending the template to generate an empty test case. I added an acceptance test to make sure that the generated tests target is testable.

@pepicrft pepicrft requested review from fortmarek and a team March 31, 2020 09:59
@pepicrft pepicrft self-assigned this Mar 31, 2020
@pepicrft pepicrft requested review from marciniwanicki and removed request for a team March 31, 2020 09:59
Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good @pepibumur 👍

@pepicrft pepicrft merged commit 1f9a446 into master Mar 31, 2020
@pepicrft pepicrft deleted the generate-test-file branch March 31, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants