Ensure DEVELOPER_DIR is used in all swiftc calls
#1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: tuist#1816 - `ProjectDescriptionHelpers` were being compiled with the default version Xcode ignoring the `DEVELOPER_DIR` environment variable, whereas the manifests were respecting the environment variable - This led to a possible mismatch in compiler versions in the case where the enviorment variable was set to an Xcode version different fromt he default (`xcode-select -p`) - To mitigate this, we now ensure all manifest loading operations (all calls to `swiftc`) respect the `DEVELOPER_DIR` environment variable Test Plan: - Set your default Xcode to 11.5 (e.g. `sudo xcode-select -s /Applications/Xcode11.5.app/Contents/Developer`) - Create a local release package of `tuist` using `bundle exec rake local_package` - Unzip `build/tuist` - Clear the tuist cache via `rm ~/.tuist/Cache` - Run `build/tuist/tuist generate --path fixtures/ios_app_with_helpers` - Set the developer dir environment to Xcode 12 (e.g. `export DEVELOPER_DIR=/Applications/Xcode12.app/Contents/Developer`) - Clear the tuist cache via `rm ~/.tuist/Cache` - Run `build/tuist/tuist generate --path fixtures/ios_app_with_helpers` - Verify project generation succeeds
pepicrft
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1816
Short description 📝
In the event
xcode-select -pmismatches the environment variableDEVELOPER_DIRtuist generatewould fail to for projects withProjectDescriptionHelpers.This was happening due to
ProjectDescriptionHelpersgetting compiled with the default version Xcode ignoring theDEVELOPER_DIRenvironment variable, whereas the manifests were respecting the environment variable causing a mismatch in Swift versions used during the loading process.Solution 📦
Ensure all manifest loading operations (all calls to
swiftc) respect theDEVELOPER_DIRenvironment variable.Implementation 👩💻👨💻
PATHwas not required, removed to minimise changes)manifestLoadingVariablesfor all manifest loading operations (to ensure consistent version of Swift is used)manifestLoadingVariablesfor all manifest hashing operations (to ensure cache is invalidated in case of switch Xcode versions)Test Plan 🛠
sudo xcode-select -s /Applications/Xcode11.5.app/Contents/Developer)tuistusingbundle exec rake local_packagebuild/tuistrm ~/.tuist/Cachebuild/tuist/tuist generate --path fixtures/ios_app_with_helpersexport DEVELOPER_DIR=/Applications/Xcode12.app/Contents/Developer)rm ~/.tuist/Cachebuild/tuist/tuist generate --path fixtures/ios_app_with_helpers