Use cache mapper #1933
Merged
Use cache mapper #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 20, 2020 13:43
…se to locate the built products directory
pepicrft
requested review from
RomainBoulay,
andreacipriani,
a team and
ollieatkinson
and removed request for
a team
andreacipriani
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
I'm introducing a bunch if improvements that are required for fixing the issue that @natanrolnik came across in the caching functionality where we were sporting transitive dependencies and doing clean builds every time we built a target:
CacheControllerto generate projects with the build phases that will be used to locate the targets' built products directory.TargetContentHasherto account for the newTarget.scriptsattribute.In a follow-up PR I'll change the logic that builds the frameworks to use the file generated by the build phase to locate the built products.