Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the swift version to 4.2 #225

Merged
merged 3 commits into from
Feb 18, 2019
Merged

Conversation

ollieatkinson
Copy link
Collaborator

Short description 📝

  • 4.2.1 is an invalid specification for SWIFT_VERSION.

Solution 📦

  • Change default to to 4.2

@pepicrft
Copy link
Contributor

There are some legit issues on CI @ollieatkinson which might be related to your changes.

@kwridan
Copy link
Collaborator

kwridan commented Feb 17, 2019

Good catch!

The fixtures need a small update:
UIApplicationLaunchOptionsKey > UIApplication.LaunchOptionsKey

Worth a rebase on master as the fixtures structure has changed slightly.

@tuistbot
Copy link
Contributor

tuistbot commented Feb 18, 2019

1 Warning
⚠️ Have you introduced any user-facing changes? If so, please take some time to update the documentation. Keeping the documentation up to date makes it easier for users to learn how to use Tuist.

Generated by 🚫 Danger

@ollieatkinson
Copy link
Collaborator Author

@kwridan I have rebased and pushed up the changes. @pepibumur Once CI gives it the green I will merge.

@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #225 into master will decrease coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage    82.3%   81.92%   -0.39%     
==========================================
  Files         247      246       -1     
  Lines        8624     8446     -178     
==========================================
- Hits         7098     6919     -179     
- Misses       1526     1527       +1
Impacted Files Coverage Δ
Sources/TuistKit/Generator/GeneratedProject.swift 0% <0%> (-100%) ⬇️
Sources/TuistKit/Models/Project.swift 16.66% <0%> (-31.55%) ⬇️
Sources/TuistKit/Models/Settings.swift 30.43% <0%> (-26.09%) ⬇️
Sources/TuistKit/Models/Target.swift 19.62% <0%> (-15.51%) ⬇️
Sources/TuistKit/Generator/SchemesGenerator.swift 45.45% <0%> (-11.69%) ⬇️
Sources/TuistKit/Graph/Graph.swift 85.51% <0%> (-1.29%) ⬇️
...itTests/Generator/Mocks/MockSchemesGenerator.swift 0% <0%> (ø) ⬆️
Sources/TuistKit/Generator/ProjectGenerator.swift 0% <0%> (ø) ⬆️
Tests/TuistKitTests/Models/TargetTests.swift 100% <0%> (ø) ⬆️
...uistKitTests/Generator/SchemesGeneratorTests.swift 100% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92f37c4...e455cef. Read the comment docs.

@pepicrft
Copy link
Contributor

Go ahead @ollieatkinson

@ollieatkinson ollieatkinson merged commit 77632b2 into master Feb 18, 2019
@ollieatkinson ollieatkinson deleted the fix-swift-4.2-buildsetting branch February 18, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants