-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the swift version to 4.2 #225
Conversation
There are some legit issues on CI @ollieatkinson which might be related to your changes. |
Good catch! The fixtures need a small update: Worth a rebase on master as the fixtures structure has changed slightly. |
Why: * 4.2.1 is an invalid specification for SWIFT_VERSION.
Generated by 🚫 Danger |
158d053
to
8e0ffcf
Compare
ec43c9d
to
e455cef
Compare
@kwridan I have rebased and pushed up the changes. @pepibumur Once CI gives it the green I will merge. |
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
- Coverage 82.3% 81.92% -0.39%
==========================================
Files 247 246 -1
Lines 8624 8446 -178
==========================================
- Hits 7098 6919 -179
- Misses 1526 1527 +1
Continue to review full report at Codecov.
|
Go ahead @ollieatkinson |
Short description 📝
Solution 📦