Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swiftlint #245

Merged
merged 2 commits into from
Feb 27, 2019
Merged

Add swiftlint #245

merged 2 commits into from
Feb 27, 2019

Conversation

pepicrft
Copy link
Contributor

Short description 📝

As @marciniwanicki suggested Swiftformat and Swiftlint have different goals and they can be used together within the same project.

Solution 📦

I've added Swiftlint back and fixed a few issues that were reported as warnings.

@pepicrft pepicrft self-assigned this Feb 27, 2019
@pepicrft pepicrft requested a review from a team February 27, 2019 13:22
Copy link
Collaborator

@ollieatkinson ollieatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏖

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #245 into master will increase coverage by 0.28%.
The diff coverage is 25.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   84.52%   84.81%   +0.28%     
==========================================
  Files         252      252              
  Lines        8919     8895      -24     
==========================================
+ Hits         7539     7544       +5     
+ Misses       1380     1351      -29
Impacted Files Coverage Δ
...rces/TuistKit/Generator/GeneratorModelLoader.swift 83.05% <ø> (ø) ⬆️
Sources/TuistKit/Graph/GraphCircularDetector.swift 100% <ø> (ø) ⬆️
Sources/TuistKit/Graph/GraphLoadingError.swift 78.12% <ø> (-0.67%) ⬇️
Sources/TuistKit/Commands/InitCommand.swift 95.15% <ø> (ø) ⬆️
Sources/TuistCore/Utils/Glob.swift 65.17% <ø> (ø) ⬆️
...urces/TuistEnvKit/GitHub/URLSessionScheduler.swift 0% <0%> (ø) ⬆️
Sources/TuistKit/Generator/ProjectGenerator.swift 10.29% <0%> (+3.07%) ⬆️
Sources/TuistKit/Linter/TargetLinter.swift 94.73% <100%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47d537...d1fd334. Read the comment docs.

@pepicrft pepicrft merged commit de422d5 into master Feb 27, 2019
@pepicrft pepicrft deleted the add-swiftlint branch February 27, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants