-
-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install script bug fix: Adding bin folder to usr/local/ when it is missing #2655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @tiarnann! I have just a small nit 🙂
script/install
Outdated
@@ -80,6 +80,7 @@ curl -LSs --output /tmp/tuistenv.zip https://storage.googleapis.com/tuist-releas | |||
ohai "Unzipping tuistenv..." | |||
unzip -o /tmp/tuistenv.zip -d /tmp/tuistenv > /dev/null | |||
ohai "Installing tuistenv..." | |||
[ ! -d "/usr/local/bin" ] && execute_sudo mkdir /usr/local/bin/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: maybe using if condition; then ... fi
might be more readable (and it's used in the shell script above?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, it makes it more readable. I added that change
@all-contributors add @tiarnann for bug |
@pepibumur I've put up a pull request to add @tiarnann! 🎉 |
* main: Rebuild frameworks Remove unnecessary step Add Luis to the core team Fix Xcode version Fix syntax issue Bump gatsby-plugin-mdx from 1.10.0 to 2.0.1 in /next (tuist#2652) Plugins: Finalize support for tuist edit (tuist#2642) Drop support for Xcode 11.x (tuist#2651) docs: add tiarnann as a contributor (tuist#2657) Install script bug fix: Adding bin folder to usr/local/ when it is missing (tuist#2655) # Conflicts: # CHANGELOG.md
Short description 📝
The install script can fail to add the
tuist
executable when thebin
folder does not exist inside/usr/local/
. I added a command to check if it does not exist and create it.Checklist ✅
CHANGELOG.md
has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.