Install script bug fix: Adding bin folder to usr/local/ when it is missing #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiarnann
changed the title
fortmarek
reviewed
Mar 14, 2021
script/install
Outdated
| @@ -80,6 +80,7 @@ curl -LSs --output /tmp/tuistenv.zip https://storage.googleapis.com/tuist-releas | |||
| ohai "Unzipping tuistenv..." | |||
| unzip -o /tmp/tuistenv.zip -d /tmp/tuistenv > /dev/null | |||
| ohai "Installing tuistenv..." | |||
| [ ! -d "/usr/local/bin" ] && execute_sudo mkdir /usr/local/bin/ | |||
There was a problem hiding this comment.
Nit: maybe using if condition; then ... fi might be more readable (and it's used in the shell script above?)
There was a problem hiding this comment.
I agree, it makes it more readable. I added that change
pepicrft
approved these changes
Mar 15, 2021
|
@all-contributors add @tiarnann for bug |
|
@pepibumur I've put up a pull request to add @tiarnann! 🎉 |
DimaMishchenko
added a commit
to DimaMishchenko/tuist
that referenced
this pull request
Mar 15, 2021
* main: Rebuild frameworks Remove unnecessary step Add Luis to the core team Fix Xcode version Fix syntax issue Bump gatsby-plugin-mdx from 1.10.0 to 2.0.1 in /next (tuist#2652) Plugins: Finalize support for tuist edit (tuist#2642) Drop support for Xcode 11.x (tuist#2651) docs: add tiarnann as a contributor (tuist#2657) Install script bug fix: Adding bin folder to usr/local/ when it is missing (tuist#2655) # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
The install script can fail to add the
tuistexecutable when thebinfolder does not exist inside/usr/local/. I added a command to check if it does not exist and create it.Checklist ✅
CHANGELOG.mdhas been updated to reflect the changes. In case of a breaking change, it's been flagged as such.