-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix tuistignore when local path are specified #3456
Conversation
9b3870e
to
e7d3ab2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a more internal feature and we do not have expectations on the syntax of .tuistignore
, I would rather change the content of the existing .tuistignore to be projects/tuist/fixtures/**
instead of projects/tuist/fixtures
rather than adding more logic. What do you think?
Not sure, I agree it's internal, but this might change in the future. |
I think if we start adding more behaviour/functionalities we may go into the direction where users would expect this to behave like |
@adellibovi I agree with your points, but in this case adding a folder would have no effect as the tuistignore works only on files, so it would be weird to have an entry which actually does nothing |
CHANGELOG entry is missing but I'll update it in |
Short description π
relative path (as the one we are specifying in Tuist own .tuistignore) were not matched correctly
Checklist β
CHANGELOG.md
has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.