-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tuist edit
when project contains a Templates folder
#4744
Fix tuist edit
when project contains a Templates folder
#4744
Conversation
Templates can import the ProjectDescriptionHelpers target/project. If a Template does this, the generated workspace/project from 'tuist edit' will sometimes not compile because the Templates target may be built before ProjectDescriptionHelpers. This change explicitly adds that dependency in the generated project to ensure ProjectDescriptionHelpers is built before Templates.
tuist edit
when project contains a Templates folder
@allcontributors add @michaelmcguire for code |
I've put up a pull request to add @michaelmcguire! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Similar issue is already happening but this time for a Plugin with Template. Template is unable to identify files, classes, etc.. from |
@mohamadrezakoohkan I have the exact same issue, did you manage to solve it? |
Resolves #4743
Short description 📝
Templates can import the ProjectDescriptionHelpers target/project. If a Template does this, the generated workspace/project from 'tuist edit' will sometimes not compile because the Templates target may be built before ProjectDescriptionHelpers. This change explicitly adds that dependency in the generated project to ensure ProjectDescriptionHelpers is built before Templates.
How to test the changes locally 🧐
Create a Tuist project with both
ProjectDescriptionHelpers
and a template where the helpers are imported. Runtuist edit --permanent
, open theManifest.xcworkspace
and make sure the workspace compiles.Checklist ✅
changelog:added
,changelog:fixed
, orchangelog:changed