Define Archive Action on Scheme

[grdsdev]

Short description 📝

The purpose of this PR is to add support for defining a custom archive action when defining a scheme, so that we're able to provide a configuration when running the archive job.

Solution 📦

The solution I propose is to follow the same implementation that is already being used on the other action's definitions.

Implementation 👩‍💻👨‍💻

• Create class ArchiveAction
• Add archiveAction attribute to Scheme class
• Implement method for generating a XCScheme.ArchiveAction from an ArchiveAction
• Implement unit tests
• Update documentation

[tuistbot]

	2 Warnings
⚠️	Please include a CHANGELOG entry. You can find it at CHANGELOG.md.
⚠️	Have you introduced any user-facing changes? If so, please take some time to update the documentation. Keeping the documentation up to date makes it easier for users to learn how to use Tuist.

Generated by 🚫 Danger

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@863cb8a). Click here to learn what that means.
The diff coverage is 33.33%.

@@           Coverage Diff            @@
##             master    #529   +/-   ##
========================================
  Coverage          ?   91.5%           
========================================
  Files             ?     358           
  Lines             ?   19373           
  Branches          ?       0           
========================================
  Hits              ?   17727           
  Misses            ?    1646           
  Partials          ?       0

Impacted Files	Coverage Δ
...neratorTests/Generator/SchemesGeneratorTests.swift	100% <100%> (ø)
Sources/TuistGenerator/Models/Scheme.swift	41.42% <12.5%> (ø)
...es/TuistGenerator/Generator/SchemesGenerator.swift	96.07% <37.5%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 863cb8a...ffded53. Read the comment docs.

[pepicrft]

Thanks for bringing this up @GRSouza. The PR is looking good 👍

[grdsdev]

Hi @pepibumur I think I'm done with the implementation, anything else I could do?

[ollieatkinson]

Looks like a welcome change, 👍.

I left a few comments, some are superficial so feel free to adhere to those as you see fit. Once you're happy with any changes or you would like me to review it again just ping back and I'll take another look and we can look at getting this merged.

[ollieatkinson]

should we update a fixture test to ensure the archive scheme can execute successfully?

[grdsdev]

Yes, it needs to be updated, how do I run the fixtures with my version of tuist? Or is another thing that needs to change?

[ollieatkinson]

Our fixtures are defined in fixtures/ and are exexuted by our cucumber test's.

To run them locally you would execute features from the Rakefile:

bundle exec rake features

Inside the generate feature you should be able to specify which action you would like Xcode to run as part of your scheme.

An example of this would be you can define a step in the cucumber tests as follows:

Then I should be able to archive for iOS the scheme App

If you are unsure of any of the above or would like me to step in then please ask

[grdsdev]

Sorry, but I don't know how this actually works. I wrote a new step as you suggested, but I'm getting the error error: use of unresolved identifier 'ArchiveAction' when a run bundle exec rake features, I guess it is because the tests aren't being run with my version of tuist.

[pepicrft]

After addressing @ollieatkinson's comment I think we are good to merge.

[pepicrft]

@GRSouza notice that the API that is available from the Project.swift is defined in the ProjectDescription framework. If you look at this file you'll see that we are not exposing any archive action and therefore you can't use it from a Project.swift file. You'll need to define the models there and extend the generation logic to map from ProjectDescription.ArchiveAction to TuistGenerator.ArchiveAction. You can use this as a reference:

• Build action in the ProjectDescription framework.
• Build action in the TuistGenerator framework.
• Mapping logic https://github.com/tuist/tuist/blob/master/Sources/TuistKit/Generator/GeneratorModelLoader.swift#L589

[pepicrft]

Also, don't forget to rebase from master.

[pepicrft]

Is it ok if I finalize this one @GRSouza?

[grdsdev]

@pepibumur it's okay, you can finalize it

[pepicrft]

I'm closing this in favor of #697, otherwise I can't push code to the branch.