New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define Archive Action on Scheme #697
Conversation
ffded53
to
cbc9141
Compare
Should I push my own pull request https://github.com/rowwingman/tuist/tree/archive-action to finish this one? Fixed errors with last two commits |
What about pushing to this one directly? You should have received a GitHub invitation to be collaborator of the organization. Once you accept it you should be able to push directly to this branch. |
a7c6248
to
45d6b37
Compare
@pepibumur can you review, and merge if everything is ok |
45d6b37
to
b5c360a
Compare
@rowwingman the following acceptance tests broke with the changes in the PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me. The acceptance test passed for me too locally. I will rebase and start submitting PRs related to #667 once this lands.
b5c360a
to
4ffb1c4
Compare
@pepibumur Looks fine after rebase |
Copied from #529
Short description π
The purpose of this PR is to add support for defining a custom archive action when defining a scheme, so that we're able to provide a configuration when running the archive job.
Solution π¦
The solution I propose is to follow the same implementation that is already being used on the other action's definitions.
Implementation π©βπ»π¨βπ»
XCScheme.ArchiveAction
from an ArchiveAction