Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Archive Action on Scheme #697

Merged
merged 1 commit into from Nov 25, 2019
Merged

Define Archive Action on Scheme #697

merged 1 commit into from Nov 25, 2019

Conversation

pepicrft
Copy link
Contributor

Copied from #529


Short description πŸ“

The purpose of this PR is to add support for defining a custom archive action when defining a scheme, so that we're able to provide a configuration when running the archive job.

Solution πŸ“¦

The solution I propose is to follow the same implementation that is already being used on the other action's definitions.

Implementation πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

  • Create class ArchiveAction
  • Add archiveAction attribute to Scheme class
  • Implement method for generating a XCScheme.ArchiveAction from an ArchiveAction
  • Implement unit tests
  • Update documentation

@pepicrft pepicrft self-assigned this Nov 19, 2019
@pepicrft pepicrft requested a review from a team November 19, 2019 17:22
@ghost ghost requested review from kwridan and ollieatkinson and removed request for a team November 19, 2019 17:22
@pepicrft pepicrft mentioned this pull request Nov 19, 2019
5 tasks
@rowwingman
Copy link
Contributor

rowwingman commented Nov 20, 2019

Should I push my own pull request https://github.com/rowwingman/tuist/tree/archive-action to finish this one? Fixed errors with last two commits

@pepicrft
Copy link
Contributor Author

What about pushing to this one directly? You should have received a GitHub invitation to be collaborator of the organization. Once you accept it you should be able to push directly to this branch.

@rowwingman rowwingman force-pushed the archive-action branch 3 times, most recently from a7c6248 to 45d6b37 Compare November 22, 2019 20:06
@rowwingman
Copy link
Contributor

@pepibumur can you review, and merge if everything is ok

@pepicrft
Copy link
Contributor Author

@rowwingman the following acceptance tests broke with the changes in the PR:

Scenario: The project is an iOS application with watch app (ios_app_with_watchapp2)                       # features/generate.feature:233
    Given that tuist is available                                                                           # features/step_definitions/shared/tuist.rb:3
      swift build
    And I have a working directory                                                                          # features/step_definitions/shared/workspace.rb:6
    Then I copy the fixture ios_app_with_watchapp2 into the working directory                               # features/step_definitions/shared/fixtures.rb:5
    Then tuist generates the project                                                                        # features/step_definitions/shared/tuist.rb:7
      swift run tuist generate --path /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/d20191124-1969-vtaw5t
    Then I should be able to build for watchOS the scheme App                                               # features/step_definitions/shared/xcode.rb:6
      xcodebuild -scheme App -workspace /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/d20191124-1969-vtaw5t/App.xcworkspace -derivedDataPath /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/d20191124-1969-vtaw5t/DerivedData clean build CODE_SIGNING_ALLOWED=NO CODE_SIGNING_IDENTITY="iPhone Developer"
      ** BUILD FAILED **

Copy link
Contributor

@adamkhazi adamkhazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me. The acceptance test passed for me too locally. I will rebase and start submitting PRs related to #667 once this lands.

@rowwingman
Copy link
Contributor

@pepibumur Looks fine after rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants