Support linting multi-destination targets #5441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the `GraphLinter` to account for multi-destination (multi-platform) targets - Lint issues are now flagged only if there are no valid source and destination platform combination based on the existing rules rather than only using the `legacyPlatform` (single platform) to base the rules on Test Plan: - Existing unit tests should continue to pass - New cases for valid and invalid combinations were addeed Notes: - This is a pre-requiste for #5381 which adds the public API for multi-desintations
pepicrft
approved these changes
Sep 28, 2023
pepicrft
force-pushed
the
update/graph-linter-multi-destinations
branch
from
eefa59c
to
3b96ade
Compare
waltflanagan
approved these changes
Sep 28, 2023
pepicrft
added
the
changelog:added
fortmarek
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
GraphLinterto account for multi-destination (multi-platform) targetslegacyPlatform(single platform) to base the rules onHow to test the changes locally 🧐
Notes 📝
ProjectDescription#5381 which adds the public API for multi-desintationsContributor checklist ✅
./fourier lint tuist --fixReviewer checklist ✅
changelog:added,changelog:fixed, orchangelog:changed, and the title is usable as a changelog entry